Compute ADM momenta as volume integrals #6433
Open
+229
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iago-mendes
force-pushed
the
volume-momenta
branch
from
11ba5c0 to
c656ebb
Compare
nilsvu
requested changes
Jan 23, 2025
| // Skip interfaces not at the outer boundary | ||
| if (boundary_direction != Direction<3>::upper_zeta()) { | ||
| continue; | ||
| // Interfaces at the inner boundary |
There was a problem hiding this comment.
You can do this to avoid duplicating all these projections:
if (boundary_direction.dimension() != 2) {
continue;
}
// Do projections| @@ -54,7 +54,7 @@ void test_local_adm_integrals(const double& distance, | |||
| const std::vector<double>& prev_distances) { | |||
| // Define black hole parameters. | |||
| const double mass = 1; | |||
| const double boost_speed = 0.5; | |||
| const double boost_speed = 0.; | |||
| @@ -198,6 +198,8 @@ void test_local_adm_integrals(const double& distance, | |||
| deriv_conformal_metric, inv_conformal_metric); | |||
| const auto conformal_christoffel_contracted = tenex::evaluate<ti::i>( | |||
| conformal_christoffel_second_kind(ti::J, ti::i, ti::j)); | |||
| const auto deriv_conformal_christoffel_second_kind = partial_derivative( | |||
There was a problem hiding this comment.
Do you need this and the longitudinal shift, Ricci additions below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR improves the accuracy of P_ADM and J_ADM by computing them as a sum of infinite volume integrals and finite surface integrals, which were derived from the standard ADM equations using Gauss' Law. We have attempted to use this same trick for other asymptotic quantities (ADM mass/energy and center of mass), but the volume version didn't improve accuracy. This is evident from the convergence plot below, in which the CoM volume results have been omitted because of blow-ups.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments