Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skew map to BCO #6447

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jan 22, 2025

Proposed changes

Adds the Skew map to the BinaryCompactObject domain. Sets it to None in all input files for now until a control system is written for it.

Part of #4603.

Upgrade instructions

When using the BinaryCompactObject domain creator, you must add the following option to the time depndent options:

  TimeDependentOptions:
    SkewMap:
      InitialValuesY: [0.0, 0.01, 0.0]
      InitialValuesZ: [0.0, 0.01, 0.0]

It has the same capabilities to be None or from a volume file as the other time dependent map options.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Depends on and includes #6446.

@knelli2 knelli2 added the dependent Needs a different PR to be merged in first label Jan 22, 2025
@knelli2 knelli2 added this to the BBH larger q & higher spins milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent Needs a different PR to be merged in first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant