Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GH dependence on ScalarTensor and Hydro #6449

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

nilsdeppe
Copy link
Member

Proposed changes

GH shouldn't depend on other evolution systems. The MHD solutions do not depend on the evolution systems and so this is would've been fine, but I think made it too easy to misunderstand the dependencies. I think the tags for ScalarTensor (and probably most of our systems) should be moved to a PointwiseFunctions/ScalarTensor directory. That's likely where most of the stuff currently in the system directory should live, with only the assembly for the executable being in the system. That would include actions, instantiations, and most of the FD/subcell code since it's not pointwise.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

GH shouldn't depend on other evolution systems. The MHD solutions do not depend
on the evolution systems and so this is would've been fine, but I think made it
too easy to misunderstand the dependencies. I think the tags for
ScalarTensor (and probably most of our systems) should be moved to a
PointwiseFunctions/ScalarTensor directory. That's likely where most of the stuff
currently in the system directory should live, with only the assembly for the
executable being in the system. That would include actions,
instantiations, and most of the FD/subcell code since it's not pointwise.
@nilsdeppe nilsdeppe requested a review from kidder January 22, 2025 14:16
@kidder kidder merged commit 517c76e into sxs-collaboration:develop Jan 24, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants