Remove GH dependence on ScalarTensor and Hydro #6449
Merged
+1,836
−1,868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
GH shouldn't depend on other evolution systems. The MHD solutions do not depend on the evolution systems and so this is would've been fine, but I think made it too easy to misunderstand the dependencies. I think the tags for ScalarTensor (and probably most of our systems) should be moved to a PointwiseFunctions/ScalarTensor directory. That's likely where most of the stuff currently in the system directory should live, with only the assembly for the executable being in the system. That would include actions, instantiations, and most of the FD/subcell code since it's not pointwise.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments