Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): remove cells text alignment inheritance #5237

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

inikolova
Copy link
Contributor

@inikolova inikolova commented Nov 19, 2024

Part of #4601

Note: removing the text-align: inherit rule will address the problem for grid content cells only. Currently header cells include an additional <span class="k-cell-inner"> element, which used Flexbox for styling. Aligning the header cells to the right requires an alternative approach to adjust the Flexbox layout and achieve the desired alignment. (Updated example from the issue - https://dojo.telerik.com/XTRvnfcl

@inikolova inikolova force-pushed the grid-cells-alignment branch from 3b768a8 to 5540c02 Compare November 19, 2024 14:25
@inikolova inikolova force-pushed the grid-cells-alignment branch from 5540c02 to 51cd88e Compare January 6, 2025 08:01
@inikolova inikolova marked this pull request as ready for review January 7, 2025 08:31
@inikolova inikolova requested a review from a team as a code owner January 7, 2025 08:31
@inikolova inikolova added Bug Something isn't working C:Grid labels Jan 7, 2025
@inikolova inikolova closed this Jan 24, 2025
@inikolova inikolova force-pushed the grid-cells-alignment branch from 51cd88e to 38e2e0a Compare January 24, 2025 08:36
@inikolova inikolova reopened this Jan 24, 2025
@inikolova inikolova added this to the 2025 Q1 (Feb) milestone Jan 24, 2025
@TeyaVes
Copy link
Contributor

TeyaVes commented Jan 24, 2025

@inikolova , For the header cell we can add k-justify-content-end utility class and the text inside will be aligned to the right without the need of custom CSS classes and rules.

@inikolova
Copy link
Contributor Author

SS classes and rules.

Yep, I will post multiple suggestions in the referenced github issue, once this PR is merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working C:Grid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants