Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): toolbar scroll buttons rendering #5306

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

TeyaVes
Copy link
Contributor

@TeyaVes TeyaVes commented Jan 22, 2025

Scroll <button> element inside Toolbar and Tabstrip is replaced with a <span> element because these elements should not be focusable. Related to: https://github.com/telerik/web-components-ux/issues/821

@TeyaVes TeyaVes force-pushed the toolbar-scroll-buttons-rendering branch from fbd1255 to 5e8989f Compare January 22, 2025 13:11
@TeyaVes TeyaVes self-assigned this Jan 22, 2025
@TeyaVes TeyaVes force-pushed the toolbar-scroll-buttons-rendering branch 4 times, most recently from a0cd602 to 5b67a87 Compare January 23, 2025 06:37
@TeyaVes TeyaVes changed the title fix(html): toolbar scroll buttons should be around by default fix(html): toolbar scroll buttons rendering Jan 23, 2025
@TeyaVes TeyaVes marked this pull request as ready for review January 23, 2025 07:30
@TeyaVes TeyaVes requested a review from a team as a code owner January 23, 2025 07:30
@TeyaVes TeyaVes force-pushed the toolbar-scroll-buttons-rendering branch 4 times, most recently from f78ae52 to e8459c0 Compare January 23, 2025 14:54
@inikolova inikolova self-requested a review January 24, 2025 08:06
@TeyaVes TeyaVes force-pushed the toolbar-scroll-buttons-rendering branch from edab3f1 to 9f2b06b Compare January 24, 2025 08:31
@TeyaVes TeyaVes merged commit b0e4fef into develop Jan 24, 2025
27 checks passed
@TeyaVes TeyaVes deleted the toolbar-scroll-buttons-rendering branch January 24, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants