feat(tool): add new resource routeros_tool_email
#632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heuels
force-pushed
the
patch-1
branch
2 times, most recently
from
b4a027b to
4d2d6f1
Compare
vaerh
requested changes
Jan 2, 2025
routeros/resource_tool_email.go
Outdated
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "Name or email address that will be shown as a receiver.", | ||
| Default: "<>", |
There was a problem hiding this comment.
Thank you very much for your contribution!
I have a request to replace all default values with DiffSuppressFunc: AlwaysPresentNotUserProvided,, we have thus solved the problem of tracking default values between different ROS versions.
This should also be done for: port, server, tls.
There was a problem hiding this comment.
Appreciate the review! I just committed these changes.
|
I also created resources today for SSTP server and client, will test and clean them up a bit tomorrow and open a PR once this one is merged 🙏🏻 |
vaerh
approved these changes
Jan 3, 2025
vaerh
approved these changes
Jan 3, 2025
|
🎉 This PR is included in version 1.74.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Needed this in my setup, figured it would be a nice thing to have in this provider.
I'm not very fluent at Go, so please let me know if anything is wrong. Thanks for your time reviewing this!
Compiled and tested this locally.