Edit pattern.md

[jariji]

I made some edits to pattern.md. I filed some issues while I was going.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6891f8) 61.18% compared to head (43e5cb9) 61.52%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   61.18%   61.52%   +0.33%     
==========================================
  Files          28       28              
  Lines        1636     1627       -9     
==========================================
  Hits         1001     1001              
+ Misses        635      626       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thautwarm]

Will review this PR and #166 today.

[thautwarm]

Things look fine to me.

It seems you discard this:

However, remember, due to some Julia optimization details, even if the guards can be put in the middle of a matching process, it is still better to postpone it until the end of matching sequence. This allows for better performance.

It's up to you whether to add the statement back. I haven't made any benchmark for the performance diff for a long time, but I do know a few cases that MLStyle's optimizations become meaningless in higher Julia version.

[thautwarm]

@jariji If you are ready for this PR to get merged, just mention me again.

[jariji]

@thautwarm I'm ready for this to be merged.

It's up to you whether to add the statement back. I haven't made any benchmark for the performance diff for a long time, but I do know a few cases that MLStyle's optimizations become meaningless in higher Julia version.

I felt that the ordering optimization was too minor an issue to be raised in introductory docs.