Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] feat: Support multiple messages in Nebula API and update input props #5972

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 17, 2025

Fixes TOOL-3132


PR-Codex overview

This PR focuses on enhancing the Nebula API by supporting multiple messages in the input structure and updating certain property names for clarity.

Detailed summary

  • Updated prompt to message in Nebula.chat and Nebula.execute.
  • Changed context to contextFilter in both functions.
  • Introduced support for multiple messages in the API input.
  • Updated tests to reflect the new input structure.
  • Enhanced documentation with examples for multi-message usage.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:40pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:40pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:40pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:40pm

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 17, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title feat: Support multiple messages in Nebula API and update input props [SDK] feat: Support multiple messages in Nebula API and update input props Jan 17, 2025
@joaquim-verges joaquim-verges force-pushed the feat_Support_multiple_messages_in_Nebula_API_and_update_input_props branch from 42b5eb3 to 4afbd2a Compare January 17, 2025 08:52
Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: 6f89de8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review January 17, 2025 08:52
@joaquim-verges joaquim-verges requested review from a team as code owners January 17, 2025 08:52
Copy link

linear bot commented Jan 17, 2025

Copy link
Contributor

github-actions bot commented Jan 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 713 ms (+38.54% 🔺) 1.7 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 1.3 s (+6.47% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 292 ms (+339.73% 🔺) 403 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 108 ms (+404.12% 🔺) 118 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 223 ms (+91.15% 🔺) 608 ms

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 54.79%. Comparing base (eed734c) to head (6f89de8).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/ai/common.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5972   +/-   ##
=======================================
  Coverage   54.79%   54.79%           
=======================================
  Files        1150     1150           
  Lines       61233    61245   +12     
  Branches     5150     5154    +4     
=======================================
+ Hits        33551    33559    +8     
- Misses      26955    26958    +3     
- Partials      727      728    +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from eed734c
packages 52.44% <0.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/ai/chat.ts 25.00% <ø> (ø)
packages/thirdweb/src/ai/execute.ts 5.88% <ø> (ø)
packages/thirdweb/src/ai/common.ts 2.77% <0.00%> (-0.35%) ⬇️

... and 3 files with indirect coverage changes

@0xFirekeeper
Copy link
Member

Makes sense but having a chat api where you just pass a string is nice though

What's the difference between user and assistant?

@furqanrydhan
Copy link
Contributor

Any chance we can support a message | messages input param for the chat interface?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants