Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs cleanup #5981

Merged
merged 5 commits into from
Jan 17, 2025
Merged

docs cleanup #5981

merged 5 commits into from
Jan 17, 2025

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented Jan 17, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

NEB-64

Notes for the reviewer

Mostly documentation updates - cleaned up icons, added images, and added section for template and SDK reference

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on removing several sidebar icon components and updating the sidebar structure, including the addition of new icons and links. It also modifies the content of the Nebula documentation pages.

Detailed summary

  • Deleted sidebar icon components: CodeIcon, EditIcon, BrickIcon, PluginIcon, RocketIcon, QuestionIcon, TroubleshootIcon.
  • Updated sidebar.tsx to use new icons: PencilRuler, ExternalLink, Rocket, Braces, Blocks, Code, Wrench, MessageCircleQuestion.
  • Added new sidebar entries: "Playground" and "SDK Reference".
  • Modified content in page.mdx to include new FAQs and updated pricing information.
  • Added support for new assets: nebula-diagram.png and supported-chains.png.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners January 17, 2025 21:12
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: f6368a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:51pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:51pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:51pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:51pm

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 17, 2025
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 21:13 Inactive
Copy link

graphite-app bot commented Jan 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 17, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 17, 2025 21:16 Inactive
Copy link
Contributor

github-actions bot commented Jan 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 246 ms (+47.49% 🔺) 1.2 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 360 ms (+6.71% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 54 ms (+449.6% 🔺) 166 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 10 ms (+300.45% 🔺) 20 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 56 ms (+67.78% 🔺) 441 ms

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.79%. Comparing base (0b62397) to head (f6368a5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5981   +/-   ##
=======================================
  Coverage   54.79%   54.79%           
=======================================
  Files        1150     1150           
  Lines       61245    61245           
  Branches     5154     5154           
=======================================
  Hits        33559    33559           
  Misses      26958    26958           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 40dd960
packages 52.44% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges merged commit a92617f into main Jan 17, 2025
30 checks passed
@joaquim-verges joaquim-verges deleted the nebula-docs-v4 branch January 17, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants