Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: Add Mode chain definition #5982

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Jan 17, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR introduces a new blockchain chain definition for mode, including its properties and exports it for use in the application.

Detailed summary

  • Added a patch for thirdweb.
  • Introduced mode as a predefined chain in packages/thirdweb/src/chains/chain-definitions/mode.ts.
  • Defined mode with properties like id, name, nativeCurrency, and blockExplorers.
  • Exported mode from packages/thirdweb/src/exports/chains.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners January 17, 2025 21:41
Copy link

linear bot commented Jan 17, 2025

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: b6d65cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:33pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:33pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:33pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:33pm

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 17, 2025
Copy link

graphite-app bot commented Jan 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl force-pushed the greg/tool-2980-adding-mode-chain-definitions branch 2 times, most recently from 3eb3d19 to 13a606b Compare January 17, 2025 21:43
Copy link
Contributor

github-actions bot commented Jan 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 424 ms (+33.23% 🔺) 1.4 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 852 ms (+28.61% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 172 ms (+293.16% 🔺) 284 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 5 ms (-70.7% 🔽) 15 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 129 ms (+9.35% 🔺) 514 ms

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (a92617f) to head (b6d65cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5982   +/-   ##
=======================================
  Coverage   54.79%   54.80%           
=======================================
  Files        1150     1151    +1     
  Lines       61245    61257   +12     
  Branches     5154     5151    -3     
=======================================
+ Hits        33559    33571   +12     
- Misses      26958    26959    +1     
+ Partials      728      727    -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a92617f
packages 52.45% <100.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ages/thirdweb/src/chains/chain-definitions/mode.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 17, 2025
Copy link
Member Author

gregfromstl commented Jan 17, 2025

Merge activity

  • Jan 17, 4:59 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 17, 5:16 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 17, 5:34 PM EST: A user merged this pull request with the Graphite merge queue.

gregfromstl added a commit that referenced this pull request Jan 17, 2025
---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new blockchain chain called `mode`, adding it to the `thirdweb` package.

### Detailed summary
- Added `mode` as a predefined chain in the `thirdweb` package.
- Exported `mode` from `packages/thirdweb/src/exports/chains.ts`.
- Defined `mode` in `packages/thirdweb/src/chains/chain-definitions/mode.ts` with properties like `id`, `name`, `nativeCurrency`, and `blockExplorers`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/tool-2980-adding-mode-chain-definitions branch from 13a606b to b28c944 Compare January 17, 2025 22:16
---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new blockchain chain called `mode` to the `thirdweb` package, enhancing the available options for developers.

### Detailed summary
- Added `mode` as a predefined chain in `packages/thirdweb/src/chains/chain-definitions/mode.ts`.
- Exported `mode` from `packages/thirdweb/src/exports/chains.ts`.
- Defined `mode` with properties such as `id`, `name`, `nativeCurrency`, and `blockExplorers`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/tool-2980-adding-mode-chain-definitions branch from b28c944 to b6d65cf Compare January 17, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants