Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance manage billing visibility in dashboard #5990

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Jan 20, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on enhancing the Billing component by adding an alert for managing plans and including a new button for billing management in the SecondaryNav.

Detailed summary

  • Added a new Button in account-button.client.tsx for "Manage Billing".
  • Introduced an Alert in Billing component with a title and description about managing the plan.
  • Included a link in the alert to external billing management instructions.
  • Added a new paragraph under the plan selection header for clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this Jan 20, 2025
@GiselleNessi GiselleNessi requested review from a team as code owners January 20, 2025 14:40
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: da507f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 10:03pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 20, 2025 10:03pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 20, 2025 10:03pm
wallet-ui ⬜️ Skipped (Inspect) Jan 20, 2025 10:03pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 20, 2025
Copy link

graphite-app bot commented Jan 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

github-actions bot commented Jan 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 2.9 s (-14.64% 🔽) 3.8 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 7.8 s (+11.91% 🔺) 10.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 437 ms (-16.37% 🔽) 549 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 544 ms (+550.24% 🔺) 554 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 774 ms (+36.16% 🔺) 1.2 s

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.77%. Comparing base (eded4ff) to head (cde3a8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5990   +/-   ##
=======================================
  Coverage   54.77%   54.77%           
=======================================
  Files        1151     1151           
  Lines       61257    61257           
  Branches     5151     5151           
=======================================
  Hits        33556    33556           
  Misses      26975    26975           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from eded4ff
packages 52.42% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 20, 2025
Copy link
Member

gregfromstl commented Jan 20, 2025

Merge activity

  • Jan 20, 4:23 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 20, 4:23 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 20, 4:34 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
  • Jan 20, 4:40 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `Manage Billing` button in the `account-button.client.tsx` file and enhances the `Billing` component with an informational `Alert` about managing plans. It also adds a description to guide users on billing management.

### Detailed summary
- Added a `Manage Billing` button in `account-button.client.tsx`.
- Introduced an `Alert` in `Billing` component with a title and description.
- Included a link in the `Alert` for managing billing.
- Added a paragraph to encourage users to upgrade or downgrade their plan.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the gi/enhance-manage-billing-visibility branch from cde3a8b to da507f1 Compare January 20, 2025 21:29
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 20, 2025 21:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 20, 2025 21:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 20, 2025 21:29 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 20, 2025
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 20, 2025
@joaquim-verges joaquim-verges merged commit 89beb3c into main Jan 20, 2025
28 of 29 checks passed
@joaquim-verges joaquim-verges deleted the gi/enhance-manage-billing-visibility branch January 20, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants