Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon sizes #1652

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix icon sizes #1652

merged 1 commit into from
Jan 2, 2025

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 1, 2025

Pull Request Description

This is a super small PR that fixes the issue mentioned in this comment: #1649 (comment)

As to why the issue suddenly happened after the latest Flutter upgrade, I'm not sure. But by specifying a size (rather than assuming/hoping it'll get the right size automatically), the problem seems to be fixed. This is probably a good thing to be doing anyway!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding and fixing the issue!

@hjiangsu hjiangsu merged commit 6cb046e into thunder-app:develop Jan 2, 2025
1 check passed
@micahmo micahmo deleted the fix/icon-sizes branch January 2, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants