Expand the production sanity test

[rwood-moz]

Add the following scenarios to the production sanity playwright E2E test:

• able to access the booking page via short link
• able to access the booking page via long link
• able to request a new booking

Here is a link to the new updated test running via GitHub actions on this branch.

And here is the corresponding recorded video of the test running in BrowserStack (if you need BrowserStack credentials just let me know and I can set you up!).

[devmount]

Just some feedback on the way 😇 Great work, thank you so much!

[rwood-moz]

Just some feedback on the way 😇 Great work, thank you so much!

Thanks for the feedback! Updated accordingly.

[malini]

do you know what code generates the time displayed in the dialog? can that logic be turned into a util and used instead of writing the getTimeFromSlotString custom function?

[rwood-moz]

Hmmm interesting idea, thanks! Another thing that might be easier or more consistent with test automation would be to add a data-testid attribute to the available time slots and it could be formatted like

data-testid='Tuesday, January 14, 2025 02:30 PM' then when the test selects an available time slot it could grab the data-testid attribute value for the selected time slot; and it would already be formatted for what we need.

[rwood-moz]

Looks like the code that generates the event time in the request sent dialog is actually generated right in the frontend itself:

https://github.com/thunderbird/appointment/blob/main/frontend/src/components/BookingModal.vue#L54

const time = computed(() => dj(props.event.start).format(dddd, MMMM D, YYYY ${timeFormat()}));

So I don't think we can go that route.

[rwood-moz]

@malini Would you mind approving this as it is? I don't see any easy way to get rid of the custom getTimeFromSLotString function unfortunately.