Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the integration tests #822

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Expand the integration tests #822

merged 2 commits into from
Jan 22, 2025

Conversation

rwood-moz
Copy link
Contributor

@rwood-moz rwood-moz commented Jan 15, 2025 •
edited
Loading

I analyzed the existing integration tests against the backend API (and created this google sheet). This PR adds new integration tests to expand test coverage and fill in some of the gaps that I noticed. Sorry it's a bit of a larger PR than I had originally anticipated.

I tested by running all of the tests locally (and also they're green in CI on this PR's related validate-backend checks).

@rwood-moz rwood-moz added the testing Issues specific to automated testing label Jan 15, 2025
@rwood-moz rwood-moz linked an issue Jan 15, 2025 that may be closed by this pull request
Review backend integration tests and ensure all API endpoints are covered #795
Closed
@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from a878371 to 36dd380 Compare January 15, 2025 21:08
@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from 36dd380 to f49e8df Compare January 15, 2025 22:34
@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from f49e8df to 5129584 Compare January 16, 2025 22:13
@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from 5129584 to 85343cb Compare January 17, 2025 16:42
@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from 85343cb to 3ded494 Compare January 17, 2025 21:01
@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from 3ded494 to c32f2d5 Compare January 20, 2025 21:32
@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from c32f2d5 to 82bcda5 Compare January 21, 2025 14:59
@rwood-moz rwood-moz marked this pull request as ready for review January 21, 2025 16:45
@MelissaAutumn MelissaAutumn self-requested a review January 21, 2025 16:47
MelissaAutumn
MelissaAutumn approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but overall excellent work! Thank you!

backend/test/integration/test_account.py Outdated Show resolved Hide resolved
backend/test/integration/test_appointment.py Outdated Show resolved Hide resolved
backend/test/integration/test_general.py Outdated Show resolved Hide resolved
backend/test/integration/test_invite.py Outdated Show resolved Hide resolved
@rwood-moz
Copy link
Contributor Author

Some nits, but overall excellent work! Thank you!

Thanks Mel, appreciated! I'll make those updates before landing.

@rwood-moz rwood-moz force-pushed the testing/expand-integration-tests branch from 82bcda5 to be56f28 Compare January 22, 2025 16:35
@rwood-moz rwood-moz merged commit 753fa24 into main Jan 22, 2025
4 checks passed
@rwood-moz rwood-moz deleted the testing/expand-integration-tests branch January 22, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelissaAutumn MelissaAutumn MelissaAutumn approved these changes

Assignees
No one assigned
Labels
testing Issues specific to automated testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review backend integration tests and ensure all API endpoints are covered
2 participants
@rwood-moz @MelissaAutumn