Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Non-Conservative BCs update #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarcoArtiano
Copy link

This PR prepares TrixiShallowWater.jl to the upcoming update in Trixi main Add flexibility to nonconservative BCs.

@MarcoArtiano MarcoArtiano changed the title Non-Conservative BCs update WIP: Non-Conservative BCs update Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 26.62%. Comparing base (8c22e65) to head (7c5ef54).

Files with missing lines Patch % Lines
src/equations/shallow_water_multilayer_2d.jl 0.00% 7 Missing ⚠️
src/equations/shallow_water_wet_dry_2d.jl 0.00% 7 Missing ⚠️
src/equations/shallow_water_multilayer_1d.jl 0.00% 6 Missing ⚠️
src/equations/shallow_water_two_layer_1d.jl 0.00% 6 Missing ⚠️
src/equations/shallow_water_exner_1d.jl 0.00% 4 Missing ⚠️
src/equations/shallow_water_wet_dry_1d.jl 0.00% 4 Missing ⚠️
...dgsem/elixir_shallowwater_three_mound_dam_break.jl 0.00% 3 Missing ⚠️
src/equations/shallow_water_two_layer_2d.jl 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8c22e65) and HEAD (7c5ef54). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (8c22e65) HEAD (7c5ef54)
5 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #64       +/-   ##
===========================================
- Coverage   99.27%   26.62%   -72.66%     
===========================================
  Files          60       60               
  Lines        2626     2524      -102     
===========================================
- Hits         2607      672     -1935     
- Misses         19     1852     +1833     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Once the modifications to Trixi.jl are settled and merged, then we can take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants