lint: Pass zapcore and zaptest packages #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
+ Coverage 98.28% 98.42% +0.14%
==========================================
Files 53 53
Lines 3493 3493
==========================================
+ Hits 3433 3438 +5
+ Misses 50 46 -4
+ Partials 10 9 -1 see 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
golangci-lint running revive currently fails on master. Exempt the dot-import failures since these are used to reduce a large number of qualifiers in the zapcore packages's _test package tests. This change also simplifies an if/else statement with a logical equivalent and standardizes a test that imported a package and a dot-import of the same package simultaneously.
r-hang
force-pushed
the
rhang/pass-revive
branch
from
1d12201 to
3850e11
Compare
sywhang
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint running revive currently fails on master. Exempt the dot-import failures since these are used to reduce a large number of qualifiers in the zapcore packages's _test package tests.
This change also simplifies an if/else statement with a logical equivalent and standardizes a test that imported a package and a dot-import of the same package simultaneously.