vaex-core: arrow: fix overflow error -- test_groupy_int8_with_null

sub: 255 - array([127],int8)
vaexio · Jan 18, 2025 · 362ce2a · 362ce2a
1 parent d235bea
commit 362ce2a
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/packages/vaex-core/vaex/arrow/numpy_dispatch.py b/packages/vaex-core/vaex/arrow/numpy_dispatch.py
@@ -84,11 +84,19 @@ def closure(op=op):
             def operator(b, a):
                 a_data = a
                 b_data = b
-                if isinstance(a, NumpyDispatch):
-                    a_data = a.numpy_array
-                if isinstance(b, NumpyDispatch):
-                    b_data = b.numpy_array
+                if isinstance(a_data, NumpyDispatch):
+                    a_data = a_data.numpy_array
+                if isinstance(b_data, NumpyDispatch):
+                    b_data = b_data.numpy_array
+
+                result_type = np.result_type(np.min_scalar_type(a_data), np.min_scalar_type(b_data))
+                if isinstance(a_data, np.ndarray):
+                    a_data = a_data.astype(result_type)
+                if isinstance(b_data, np.ndarray):
+                    b_data = b_data.astype(result_type)
+
                 result_data = op['op'](a_data, b_data)
+
                 if isinstance(a, NumpyDispatch):
                     result_data = a.add_missing(result_data)
                 if isinstance(b, NumpyDispatch):