Add numpy2 support #2449
Open
Add numpy2 support #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added test_weights_2d - interpolate marked as failing
Removing vaex.vaexfast.Error in favor of using std errors
Adressing:
/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/vaex/strings.py:10: in <module>
from .superstrings import *
E ImportError: libpcrecpp.so.0: cannot open shared object file: No such file or directory
…merge supposed to do here
|
Handling: ValueError: Unable to avoid copy while creating an array as requested
…alue to int8 Note, that this might need deeper investigation and handling in the hash classes. However, for the masking when comparing to legacy behaviour, it looks as if null_index will be converted to -1.
|
Great progress! ❤️ Is the plan to also maintain numpy v1 runtime support? |
expression: '((255 - (g - -128)) + -128)' result = sub(255, array([127],int8))
True -> np.True_ and False -> np.False_
For now, yes, should still run with v1, and so far it does considering ci and 3.9 (uses numpy==1.26.4) |
…find_edges percentile_approx_test fails with nan in the result array, caused by vaex.vaexfast.grid_find_edges returning edges_floor / edges_ceil with [from, to] where from == to
|
All outstanding issues related to numpy v2 (and some not) are resolved - only catboost dependent functionality is conditionally disabled. All pipelines run fine - even some previously skipped tests. |
|
awesome work! ❤️ @maartenbreddels if we get lucky, the pybind submodule update in this PR will also solve #2442 |
ddelange
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request intends to enable the use of numpy2 (#2446 #2425) with vaex.
In addition it applies some other fixes.
An (incomplete) summary:
Note, that I encountered some broken test(s) in cmodule.py test_interpolate and those related to Webserver:
Some format changes from tab to space indent have been applied.
Please let me know if (further) changes are required - only validated on Linux system right now.
I ran tests in vaex-core/vaex/test - any more instructions on how to run you full test-suite (apart from ci)?
Thx.
@maartenbreddels @ddelange