Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially pointed out in #1966 to adapt
isStrongPassword
to return count of all type of characters in the password.The responsibility of
isStrongPassword
should only be to check if the password is strong or not. So instead of modifyingisStrongPassword
,analyzePassword
is exported which can be used to know the count of all type of characters in the password.The issue is also attempted to solve here #2033
Checklist