refactor: appending inner error (#298)

vechain · Nov 27, 2023 · a64f364 · a64f364 · github-actions · Nov 27, 2023
1 parent 095661f
commit a64f364
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/packages/core/src/keystore/keystore.ts b/packages/core/src/keystore/keystore.ts
@@ -75,7 +75,15 @@ async function decrypt(
             password
         )) as KeystoreAccount;
     } catch (e) {
-        throw buildError(KEYSTORE.INVALID_PASSWORD, 'Invalid password');
+        throw buildError(
+            KEYSTORE.INVALID_PASSWORD,
+            'Invalid password',
+            {
+                keystore,
+                password
+            },
+            e
+        );
     }
 }
 

diff --git a/packages/network/src/clients/thorest-client/transactions/transactions-client.ts b/packages/network/src/clients/thorest-client/transactions/transactions-client.ts
@@ -134,7 +134,8 @@ class TransactionsClient {
             throw buildError(
                 DATA.INVALID_DATA_TYPE,
                 'Invalid raw transaction given as input. Input must be a valid raw transaction. Error occurs while decoding the transaction.',
-                { raw }
+                { raw },
+                error
             );
         }
 

diff --git a/packages/network/src/utils/http/http-client.ts b/packages/network/src/utils/http/http-client.ts
@@ -70,9 +70,9 @@ class HttpClient {
             // If it's not an Axios error, re-throw the original error
             throw buildError(
                 HTTP_CLIENT.INVALID_HTTP_REQUEST,
-                `An error occurred while performing http request ${JSON.stringify(
-                    err
-                )}`
+                `An error occurred while performing http request`,
+                { method, path, params },
+                err
             );
         }
     }
Title	Tests	Time
core	319	1m 32s ⏱️
network	71	54.117s ⏱️
errors	30	11.58s ⏱️