fix: remove hash helpers error constant

vechain · Oct 30, 2023 · e543738 · e543738
1 parent a92290c
commit e543738
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 34 deletions.
diff --git a/packages/core/src/hash/blake2b256.ts b/packages/core/src/hash/blake2b256.ts
@@ -1,6 +1,7 @@
 import blake from 'blakejs';
 import { type HashInput, type ReturnType } from './types';
-import { createInvalidReturnTypeError, isValidReturnType } from './helpers';
+import { isValidReturnType } from './helpers';
+import { buildError, DATA } from '@vechain-sdk/errors';
 
 /**
  * Internal function to compute the blake2b256 256-bit hash of the given data.
@@ -73,7 +74,10 @@ function blake2b256(
     returnType: ReturnType = 'buffer'
 ): Buffer | string {
     if (!isValidReturnType(returnType)) {
-        throw createInvalidReturnTypeError();
+        throw buildError(
+            DATA.INVALID_DATA_RETURN_TYPE,
+            "Invalid return type. Return type should be either 'buffer' or 'hex'"
+        );
     }
 
     // Converts the data to an array of Buffer or string

diff --git a/packages/core/src/hash/helpers/hashhelpers.ts b/packages/core/src/hash/helpers/hashhelpers.ts
diff --git a/packages/core/src/hash/helpers/index.ts b/packages/core/src/hash/helpers/index.ts
diff --git a/packages/core/src/hash/keccak256.ts b/packages/core/src/hash/keccak256.ts
@@ -1,6 +1,7 @@
 import { ethers } from 'ethers';
 import { type ReturnType, type HashInput } from './types';
-import { createInvalidReturnTypeError, isValidReturnType } from './helpers';
+import { isValidReturnType } from './helpers';
+import { buildError, DATA } from '@vechain-sdk/errors';
 
 /* --- Overloaded functions start --- */
 
@@ -52,7 +53,10 @@ function keccak256(
     returnType: ReturnType = 'buffer'
 ): Buffer | string {
     if (!isValidReturnType(returnType)) {
-        throw createInvalidReturnTypeError();
+        throw buildError(
+            DATA.INVALID_DATA_RETURN_TYPE,
+            "Invalid return type. Return type should be either 'buffer' or 'hex'"
+        );
     }
 
     const hash = ethers.isBytesLike(data)

diff --git a/packages/core/src/hash/sha256.ts b/packages/core/src/hash/sha256.ts
@@ -1,6 +1,7 @@
 import { ethers } from 'ethers';
 import { type ReturnType, type HashInput } from './types';
-import { createInvalidReturnTypeError, isValidReturnType } from './helpers';
+import { isValidReturnType } from './helpers';
+import { buildError, DATA } from '@vechain-sdk/errors';
 
 /* --- Overloaded functions start --- */
 
@@ -51,7 +52,10 @@ function sha256(
     returnType: ReturnType = 'buffer'
 ): Buffer | string {
     if (!isValidReturnType(returnType)) {
-        throw createInvalidReturnTypeError();
+        throw buildError(
+            DATA.INVALID_DATA_RETURN_TYPE,
+            "Invalid return type. Return type should be either 'buffer' or 'hex'"
+        );
     }
 
     const hash = ethers.isBytesLike(data)