Implement ThorClient and Account :: EOA :: Online #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
fabiorigam
changed the title
Test CoverageSummary
|
| */ | ||
| constructor( | ||
| protected readonly httpClient: IHttpClient, | ||
| readonly genesis: Block, |
There was a problem hiding this comment.
Do we need the genesis when making a thor client? It's a pain to find / configure IMO
There was a problem hiding this comment.
@claytonneal I know you hated this part about connex 😂
There was a problem hiding this comment.
IMO, it's better to have an async function to get the genesis block
There was a problem hiding this comment.
We are removing it don't worry
|
Refactored the initial structure in #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Waiting for #196 to be approved