Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Request poll #293

Merged
merged 39 commits into from
Nov 28, 2023
Merged

feat: Request poll #293

merged 39 commits into from
Nov 28, 2023

Conversation

rodolfopietro97
Copy link
Contributor

@rodolfopietro97 rodolfopietro97 commented Nov 23, 2023 •
edited
Loading

Creation of request polling

  • Synchronous
  • Asynchronous
  • Example in the doc
    • Testnet
    • Solo (wait to merge ...)

@rodolfopietro97 rodolfopietro97 marked this pull request as draft November 23, 2023 10:18
This was linked to issues Nov 23, 2023
Request polling, Investigation #232
Closed
Start with basically request polling implementation #281
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 100%
 100% (1160/1160) 100% (277/277) 100% (239/239)
Title Tests Skipped Failures Errors Time
core 319 0 💤 0 ❌ 0 🔥 1m 42s ⏱️
network 79 0 💤 0 ❌ 0 🔥 1m 5s ⏱️
errors 30 0 💤 0 ❌ 0 🔥 14.039s ⏱️

fabiorigam
fabiorigam reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@fabiorigam fabiorigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a comment

packages/network/tests/utils/poll/sync-poll.solo.test.ts Outdated Show resolved Hide resolved
packages/network/tests/utils/poll/sync-poll.testnet.test.ts Outdated Show resolved Hide resolved
pierobassa
pierobassa reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@pierobassa pierobassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Left some considerations before continuing

packages/network/src/utils/poll/sync.ts Outdated Show resolved Hide resolved
packages/network/src/utils/poll/sync.ts Outdated Show resolved Hide resolved
packages/network/src/utils/poll/sync.ts Outdated Show resolved Hide resolved
packages/network/src/utils/poll/sync.ts Show resolved Hide resolved
packages/network/src/utils/poll/sync.ts Outdated Show resolved Hide resolved
packages/network/src/utils/poll/event.ts Outdated Show resolved Hide resolved
packages/network/src/utils/poll/event.ts Outdated Show resolved Hide resolved
packages/network/tests/utils/poll/event/event-poll.unit.test.ts Outdated Show resolved Hide resolved
packages/errors/src/model/network/poll.ts Outdated Show resolved Hide resolved
packages/errors/src/model/network/poll.ts Outdated Show resolved Hide resolved
@pierobassa pierobassa mentioned this pull request Nov 27, 2023
Closed
1 task
@rodolfopietro97 rodolfopietro97 marked this pull request as ready for review November 28, 2023 09:44
@rodolfopietro97 rodolfopietro97 merged commit 01a9709 into main Nov 28, 2023
9 checks passed
@rodolfopietro97 rodolfopietro97 deleted the feat-request-polling branch November 28, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiorigam fabiorigam fabiorigam approved these changes

@pierobassa pierobassa Awaiting requested review from pierobassa

@claytonneal claytonneal Awaiting requested review from claytonneal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start with basically request polling implementation Request polling, Investigation
4 participants
@rodolfopietro97 @claytonneal @pierobassa @fabiorigam