Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 514 - Improve test naming #564

Merged
merged 8 commits into from
Feb 14, 2024
Merged

Conversation

lucanicoladebiasi
Copy link
Collaborator

Test source files are named to specify which involve mock, testnet, solo, or combine them.

rodolfopietro97 and others added 8 commits February 13, 2024 10:48
* feat: debug_traceTransaction with tests

* feat: debug_traceCall with tests and rename test of debug_traceTransacion

* fix: removed destroy not needed

* fix: increrased test time

* fix: remove not used variable
Bumps [ethers](https://github.com/ethers-io/ethers.js) from 6.10.0 to 6.11.0.
- [Release notes](https://github.com/ethers-io/ethers.js/releases)
- [Changelog](https://github.com/ethers-io/ethers.js/blob/main/CHANGELOG.md)
- [Commits](ethers-io/ethers.js@v6.10.0...v6.11.0)

---
updated-dependencies:
- dependency-name: ethers
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@ethereumjs/rlp](https://github.com/ethereumjs/ethereumjs-monorepo) from 5.0.1 to 5.0.2.
- [Release notes](https://github.com/ethereumjs/ethereumjs-monorepo/releases)
- [Commits](https://github.com/ethereumjs/ethereumjs-monorepo/compare/@ethereumjs/[email protected]...@ethereumjs/[email protected])

---
updated-dependencies:
- dependency-name: "@ethereumjs/rlp"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabio Rigamonti <[email protected]>
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.7 to 0.25.8.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.25.7...v0.25.8)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabio Rigamonti <[email protected]>
Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) from 18.6.0 to 18.6.1.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v18.6.1/@commitlint/config-conventional)

---
updated-dependencies:
- dependency-name: "@commitlint/config-conventional"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabio Rigamonti <[email protected]>
Bumps [husky](https://github.com/typicode/husky) from 9.0.10 to 9.0.11.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v9.0.10...v9.0.11)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabio Rigamonti <[email protected]>
…558)

* refactor: start polling instance only when a subscription is active

* test: no best block when calling eth_subscribe

* feat: set pollInstance to undefined after stop listening
* fix: improve chain_id RPC and relative tests

* fix: update eth_getBalance comments

* fix: update eth_getCode comments

* fix: update comments for eth_getStorageAt

* fix: rename format functions

* fix: update eth_getBlockByHash comments

* fix: remove unused interface and improve comments

* fix: improve code quality

* fix: improve eth_chainId

* fix: update eth_chainId

* fix: chainid

---------

Co-authored-by: rodolfopietro97 <[email protected]>
@lucanicoladebiasi lucanicoladebiasi self-assigned this Feb 14, 2024
@lucanicoladebiasi lucanicoladebiasi requested a review from a team as a code owner February 14, 2024 14:19
@lucanicoladebiasi lucanicoladebiasi merged commit 6f2881d into 514-improve-test-naming Feb 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants