Update snapshot unit test, the stack is changed because we resolve th…

…e Vc earlier
vercel · Jan 21, 2025 · a1d3b24 · a1d3b24
1 parent 0b5a836
commit a1d3b24
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/turbopack/crates/turbopack-tests/tests/execution.rs b/turbopack/crates/turbopack-tests/tests/execution.rs
@@ -172,7 +172,7 @@ async fn run(resource: PathBuf, snapshot_mode: IssueSnapshotMode) -> Result<JsRe
     tt.run_once(async move {
         let emit_op =
             run_inner_operation(resource.to_str().unwrap().into(), Value::new(snapshot_mode));
-        let result = emit_op.connect().strongly_consistent().await?;
+        let result = emit_op.read_strongly_consistent().await?;
         apply_effects(emit_op).await?;
 
         Ok(result.clone_value())
@@ -452,12 +452,12 @@ async fn run_test_operation(prepared_test: ResolvedVc<PreparedTest>) -> Result<V
 #[turbo_tasks::function]
 async fn snapshot_issues(
     prepared_test: Vc<PreparedTest>,
-    run_result: OperationVc<RunTestResult>,
+    run_result_op: OperationVc<RunTestResult>,
 ) -> Result<Vc<()>> {
     let PreparedTest { path, .. } = *prepared_test.await?;
-    let _ = run_result.connect().resolve_strongly_consistent().await;
+    let _ = run_result_op.resolve_strongly_consistent().await;
 
-    let captured_issues = run_result.peek_issues_with_path().await?;
+    let captured_issues = run_result_op.peek_issues_with_path().await?;
 
     let plain_issues = captured_issues
         .iter_with_shortest_path()

diff --git a/turbopack/crates/turbopack-tests/tests/snapshot.rs b/turbopack/crates/turbopack-tests/tests/snapshot.rs
@@ -159,7 +159,7 @@ async fn run(resource: PathBuf) -> Result<()> {
     let tt = TurboTasks::new(MemoryBackend::default());
     let task = tt.spawn_once_task(async move {
         let emit_op = run_inner_operation(resource.to_str().unwrap().into());
-        emit_op.connect().strongly_consistent().await?;
+        emit_op.read_strongly_consistent().await?;
         apply_effects(emit_op).await?;
 
         Ok(Vc::<()>::default())
@@ -173,8 +173,7 @@ async fn run(resource: PathBuf) -> Result<()> {
 #[turbo_tasks::function(operation)]
 async fn run_inner_operation(resource: RcStr) -> Result<()> {
     let out_op = run_test_operation(resource);
-    let out_vc = out_op.connect();
-    let _ = out_vc.resolve_strongly_consistent().await?;
+    let out_vc = out_op.resolve_strongly_consistent().await?;
     let captured_issues = out_op.peek_issues_with_path().await?;
 
     let plain_issues = captured_issues

diff --git a/...eration for chunk item errored-2c5cf4.txt → ...eration for chunk item errored-1c3f39.txt b/...eration for chunk item errored-2c5cf4.txt → ...eration for chunk item errored-1c3f39.txt
@@ -6,7 +6,6 @@ error - [code gen] [project]/turbopack/crates/turbopack-tests/tests/snapshot/imp
 
   Debug info:
   - An error occurred while generating the chunk item [project]/turbopack/crates/turbopack-tests/tests/snapshot/imports/json/input/invalid.json (json)
-  - Execution of *EcmascriptChunkItemContent::module_factory failed
   - Execution of <JsonChunkItem as EcmascriptChunkItem>::content failed
   - Unable to make a module from invalid JSON: expected `,` or `}` at line 3 column 26
       at nested.?

diff --git a/...son/output/turbopack_crates_turbopack-tests_tests_snapshot_imports_json_input_52abdb._.js b/...son/output/turbopack_crates_turbopack-tests_tests_snapshot_imports_json_input_52abdb._.js