[Turbopack] fail safe on binary import to string #75056
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue muxinc/next-video#266
Related discussion #72147
What?
This fixes an issue with Turbopack when importing binary files like image, videos.
Why?
Currently the build process will crash if Turbopack tries to convert a binary file import to a string.
For next-video this functionality is required though we don't use the binary content. It's more about the import path and file name.
example output:
How?
This is a simple try / catch around the content to string conversion. If the conversion fails the content is set to an empty string for now. I considered converting to base64 so it could still be used in the JS Webpack loader but I have concerns that could slow down the build process too much.
In the future I hope Turbopack can support the Webpack "raw" option to pass the content as bytes.