Fix: domain routing redirects #75115
Open
+212
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aims to fix a redirection issue when domain routing and redirect rules are used together in
next.config.js.This generates rules with absolute URLs, redirecting the request to an incorrect domain and a different host from where it came from.
How to replicate?
test/e2e/i18n-default-locale-redirect/app/next.config.jsI'm navigating localhost, but once the redirection matches, I get redirected to example.nl as it's the first matched rule. I expect to be redirected `/nl/new` keeping the same host.
How to fix?
Avoid adding domain routing to redirects array fixes the issue.
Tests added.
Fixes #68388