-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbopack: don't generate CSS for Node.js #75117
Open
mischnic
wants to merge
24
commits into
canary
Choose a base branch
from
mischnic/no-ssr-css
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+456
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
PRs by the Turbopack team.
Turbopack
Related to Turbopack with Next.js.
labels
Jan 20, 2025
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for edge-ssr.jsDiff too large to display Diff for 5306-HASH.jsDiff too large to display Diff for main-HASH.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsDiff too large to display Diff for app-page-exp..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page.runtime.dev.jsDiff too large to display Diff for app-page.runtime.prod.jsDiff too large to display Diff for server.runtime.prod.jsDiff too large to display |
mischnic
changed the title
Turbopack: no CSS for Node.js
Turbopack: don't generate CSS for Node.js
Jan 21, 2025
mischnic
force-pushed
the
mischnic/no-ssr-css
branch
from
January 21, 2025 14:15
be3f42b
to
6c724c5
Compare
mischnic
changed the base branch from
canary
to
mischnic/css-chunking-isolated
January 21, 2025 14:15
mischnic
force-pushed
the
mischnic/css-chunking-isolated
branch
from
January 21, 2025 19:34
8a99ac5
to
5e2a1c0
Compare
mischnic
force-pushed
the
mischnic/no-ssr-css
branch
2 times, most recently
from
January 21, 2025 20:06
bd88710
to
886d6b9
Compare
This reverts commit c83d2cba32ceb97907c078804b700965ae44a507.
mischnic
force-pushed
the
mischnic/no-ssr-css
branch
from
January 22, 2025 10:00
886d6b9
to
ab4add3
Compare
mischnic
changed the base branch from
mischnic/css-chunking-isolated
to
canary
January 22, 2025 12:42
I've unstacked this from #75139, because I ended up simplifying CSS client references (by handling the CSS Modules differently) |
sokra
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
created-by: Turbopack team
PRs by the Turbopack team.
tests
Turbopack
Related to Turbopack with Next.js.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FullContextTransition
to not inherit the RSC transitionsChunkingType::Isolated
Memory usage went slightly down: 38.96gb -> 38.23gb
CPU time went down: 784.97s -> 747.57s
There are 200.000 fewer
emit asset
calls (so 20%).