feat: improve metrics of next #12862
Conversation
🦋 Changeset detectedLatest commit: 3a5baf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fix: rename TimeTracking to Metrics fix: remove the Ms suffix fix: move the logic to a new file fix: cleanup fix: tests fix: tests fix: tests fix: tests
marc-vercel
force-pushed
the
bd-1494-improve-metrics
branch
from
633e442 to
623f15b
Compare
packages/next/src/index.ts
Outdated
| metrics: { | ||
| install: installExecutionTime, | ||
| build: buildExecutionTime, | ||
| }, |
There was a problem hiding this comment.
We should keep in mind future metrics or details we want to capture about builds when changing this interface. For example, we'll want to capture which package manager was used and how successful it was for the install step.
We could end up with something like:
metrics: {
install: {
duration: installExecutionTime,
packageManager,
isSatisfiedByBuildCache,
}
}
Or we add that data elsewhere later.
I suggest that the interface here start with:
| metrics: { | |
| install: installExecutionTime, | |
| build: buildExecutionTime, | |
| }, | |
| metrics: { | |
| install: { | |
| duration: installExecutionTime | |
| }, | |
| build: { | |
| duration: buildExecutionTime | |
| } | |
| }, |
There was a problem hiding this comment.
Thanks for the reply @EndangeredMassa! I will do that.
Also, I see that the test test-e2e (examples, 3, ubuntu-latest, Node v16) keeps failing, and it does not seem a flaky test. Do you know which may be the cause? Afaik I've not change anything from ionic-react and I'm struggling a bit to find the root cause.
There was a problem hiding this comment.
Sorry about that ionic-react failure, I was working on that. Started a rerun and it should succeed now!
No description provided.