remove(deployment): the 'replicas' field from the helm template if not used by user

[alexis974]

What does this MR do?

Remove the 'replicas' field from the helm template if set to null by user.

Why was this MR needed?

If you are using Keda to auto-scale your runner, it will modify the 'spec.replicas' of the deployment. That will cause a drift from the manifest known to ArgoCD. Therefore ArgoCD resync the resource. But then Keda retry to update it, and so on.....

By modifing the deployment template, we ensure that the replicas field is not present in the helm template if set to null by the user, and therefore not watch by ArgoCD. Note that by default, Kubernetes will set de 'spec.replicas' field to 1 if not present.

What's the best way to test this MR?

Do three helm template:

• One with replicaCount to 1
• One with replicaCount to 0
• One with replicaCount to null

[alexis974]

Could you take a look @juanpicado ?

[alexis974]

Hello @juanpicado , sorry about the failed check. I bumped the chart version.

[juanpicado]

There is an error to address , feel free to check it out them I'll merge fast as possible.

[alexis974]

Hi @juanpicado, sorry for the long delay.
Could you trigger the workflow again ?

[alexis974]

I updated the documentation. I seems that you need to re-trigger the workflow @juanpicado . Sorry for that :/

[juanpicado]

Thanks :)