Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Shortcutting Min-max Observer #887

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Allow Shortcutting Min-max Observer #887

wants to merge 10 commits into from

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Nov 1, 2024 •
edited
Loading

Purpose

Changes

  • Renamed MovingAverageMinMaxObserver -> MinMaxObserver since moving average is not required to use it
  • Shortcut averaging logic by checking self.averaging_constant == 1.0
  • Update docstrings, ect.

Testing

  • Ran examples/quantization_w4a16/llama3_example.py to completion

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@kylesayrs kylesayrs marked this pull request as ready for review November 4, 2024 21:46
@kylesayrs kylesayrs self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsikka dsikka dsikka approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@kylesayrs kylesayrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylesayrs @dsikka