-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Cache fix for GenerateTask #1006
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 2b6586a.
This project currently supports Gradle version 5.6 but this PR is using Gradle 8. I think it is not reasonable to break compatibility for people who are still using older versions of Gradle. I would consider updating minimal Gradle version to 6. |
I changed it to match your requirements ;) |
Hello, would you consider merging this PR? |
Hello @IgorDomagala Thank you very much for your contribution! After some testing it seems your PR is not compatible with For example with this configuration
I get the following error:
Do you have an idea of what could cause this? |
Using typescript-plugin (v3.2.1263) with configuration cache enabled results in error:
type `cz.habarta.typescript.generator.gradle.GenerateTask`: cannot serialize object of type 'org.gradle.api.tasks.compile.JavaCompile', a subtype of 'org.gradle.api.Task', as these are not supported with the configuration cache.
and many more, mostly because GenerateTask uses variable "project" directly.
You can reproduce this error by running
./gradlew --configuration-cache --rerun-tasks assemble
.This pull request fixes it by changing way of class loading and getting classpath.
This PR also adds Gradle configuration cache test.