Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #3853

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update docs #3853

wants to merge 1 commit into from

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Dec 4, 2024

The default configuration should no longer use the proportion plugin

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hwdef
You can assign the PR to them by writing /assign @hwdef in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2024
@hwdef
Copy link
Member Author

hwdef commented Dec 4, 2024

/assign @Monokaix @JesseStutler

@hwdef hwdef force-pushed the update-docs branch 2 times, most recently from 24969f4 to f39e119 Compare December 4, 2024 02:48
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2024
@hwdef
Copy link
Member Author

hwdef commented Dec 4, 2024

/assign @lowang-bh

Monokaix
Monokaix reviewed Dec 5, 2024
View reviewed changes
docs/design/proportional.md Outdated
@@ -1,3 +1,7 @@
## Deprecated

The `proportion` is deprecated. It is replaced by [capacity](capacity-scheduling.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proportional and proportion are different plugins: )
And proportion is actually not deprecated, proportion and capacity are just two ways using queue and cover different use cases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hierarchical queue function may not be compatible with proportion.

@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
@Monokaix
Copy link
Member

Monokaix commented Dec 5, 2024

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@archlitchi archlitchi Awaiting requested review from archlitchi

@shinytang6 shinytang6 Awaiting requested review from shinytang6

At least 1 approving review is required to merge this pull request.

Assignees

@Monokaix Monokaix

@lowang-bh lowang-bh

@JesseStutler JesseStutler

Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwdef @volcano-sh-bot @Monokaix @lowang-bh @JesseStutler