Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volcano-devices unified config #3953

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

archlitchi
Copy link
Contributor

@archlitchi archlitchi commented Jan 3, 2025

/kind feature

/area scheduling

After last Friday's discussion, we decided to use sync.once to initialize device config from configmap once during initializing. This Feature is used combined with latest version of 'https://github.com/Project-HAMi/volcano-vgpu-device-plugin'

This PR exposes vGPU resourceName as #3926 does, Using device--configMap is a better than using scheduler-configmap, since device-config can be accessed by volcano-vgpu-device-plugin.

To be noticed:

  1. This feature is fully compatible with earlier versions, a default config will be generated if CM not found.
  2. The information got by configs is not processed now, it will be used for future dynamic-mig implementation
  3. This PR won't change the behavior of volcano-vgpu feature, dynamic-mig is not implemented in this PR
  4. This PR fix issue:We'd better not depend on a kubeconfig file #3473

@volcano-sh-bot volcano-sh-bot added kind/feature Categorizes issue or PR as related to a new feature. area/scheduling labels Jan 3, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants