add params rhel_satellite #1032
Conversation
There was a problem hiding this comment.
@flepoutre: Thanks for this. I had an idea this might cause a problem, but because there's no working CI setup for acceptance tests that works for this module on RHEL (there is an image, but IIRC, there are non-available required packages that make practically using it for Puppet tests difficult), it was hard to know for sure, and also didn't know what the desired behavior would be in the case of RHEL.
High level, I think this is about the right fix, but I think we should do a combination of:
- A bit more magic internally
and / or - Rename the parameter to something more consistent and generic (like
enable_centos_release(bool)).
I think we're trying to do less of "data in modules", so the fix of setting the param default to true when the exact OS is CentOS, and false otherwise might not work.
But we can probably use a combination of facts and defaults to get this to a somewhat better place.
You'll also need to update the generated docs, and possibly adjust one or two spec tests.
|
Please update REFERENCE.md with Also, parameter name is confusing. I'd say the whole logic there is confusing. From my point of view, it should be under |
Add an `enable_centos_release` parameter, defaulting to `false`, except on CentOS, where it defaults to `true. If enabled on any OS in the RedHat family when `repos_ensure` is also disabled, it controls adding the `centos-release-rabbitmq` package (currently `centos-release-rabbitmq-38`) Fixes voxpupuli#1033 Closes voxpupuli#1032
|
This is a kind of wonky one. I implemented something that I think will resolve this in #1034 – hope that’s ok? |
Hello,
The purpose of this PR is to not install the
centos-release-rabbitmq-38package if we used RHEL satellite.Can you please take it into account ?
Thanks.