CentOS7: default to EPEL7 as source #983
Conversation
bastelfreak
force-pushed
the
epel
branch
5 times, most recently
from
16f3435 to
c9c40a4
Compare
bastelfreak
changed the title
| @@ -505,6 +507,8 @@ | |||
| default: { | |||
| } | |||
| } | |||
| } elsif ($facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '7') { | |||
| require epel | |||
There was a problem hiding this comment.
I don't have a strong opinion on how we should call the epel module. We could also just add it to the acceptance tests or introduce another parameter for it.
Historically we used the garethr/erlang module as soft dependency on CentOS 7. This also configured the EPEL7 repository. I always always a bit unsure where the actual rabbitmq packages come from. I assumed somehow from the erlang repo. My impression is that the erlan repo isn't used at all. rabbitmq packages where always pulled from EPEL7. The problem with the garethr/erlang is that it depends on the deprecated `stahnma/epel` (which is now puppet/epel) and uses topscope facts and variables. The module doesn't work anymore with Puppet 8. This PR replaces the unused garethr/erlang directly with the EPEL module.
|
The actual rmq packages used to come from packagecloud, and then we switched to them coming from the OS vendor repo. They did not ever come from the Erlang repo, but I believe they had a dependency on some version of Erlang being installed that perhaps the package itself did not satisfy? This was ancient history, though. this makes sense to me if it works, though may make sense to ship the other, safer changes first since there are a bunch. |
|
If #979 looks good to you as-is, let's do that; also, is it possible that CentOS 8 (see #900) will now work, though based on https://en.wikipedia.org/wiki/CentOS, seems like CentOS 8 actually was already EOLed a long time ago, and 7 will be next month? |
|
We already started dropping CentOS 7 in some repos (https://voxpupuli.org/blog/2024/05/08/CentOS-7-CentOS-Stream-8-deprecation/) but it would be nice to have one release where it's actually fixed. And the updated dependencies will make it easier for users to upgrade. |
Historically we used the garethr/erlang module as soft dependency on CentOS 7. This also configured the EPEL7 repository. I always always a bit unsure where the actual rabbitmq packages come from. I assumed somehow from the erlang repo. My impression is that the erlan repo isn't used at all. rabbitmq packages where always pulled from EPEL7. The problem with the garethr/erlang is that it depends on the deprecated
stahnma/epel(which is now puppet/epel) and uses topscope facts andvariables. The module doesn't work anymore with Puppet 8.
This PR replaces the unused garethr/erlang directly with the EPEL module.