puppetlabs/stdlib: Allow 9.x #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
approved these changes
May 19, 2024
wyardley
reviewed
May 19, 2024
bastelfreak
added a commit
to bastelfreak/puppet-rabbitmq
that referenced
this pull request
May 19, 2024
Also contains voxpupuli#986
|
that's why I want to get the puppet 8 PR in. CI will fail on puppet 8 when we use deprecated functions. |
|
Seems like this one passes now, though? With or without Puppet 8, does it make sense to drop support for older stdlib as a breaking change (with removal of those methods)? I'm good either way - if you think this one is good, let's |
bastelfreak
force-pushed
the
stdlib9_20230723
branch
from
bdfa8fd to
202a017
Compare
bastelfreak
added a commit
to bastelfreak/puppet-rabbitmq
that referenced
this pull request
May 19, 2024
Also contains voxpupuli#986
|
I noticed that the GH UI isn't setup to suggest / warn when the base needs to be updated if there are no conflicts - would it make sense to add that in the branch protection settings if someone's got that power? |
TheMeier
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues