Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Idempotence issue for RHEL 7 forwarder install #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Idempotence issue for RHEL 7 forwarder install #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion manifests/forwarder.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@
mode => $facts['kernel'] ? {
'windows' => undef,
default => '0600',
}
},
seluser => 'unconfined_u',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is right. If on the second run, puppet wants to set it to system_u that's probably because a new selinux module has been installed with the RPM and the type should be system_u. I think there's also a high probability users are bumping into https://tickets.puppetlabs.com/browse/PUP-2169 which puppet apply (as used in the acceptance tests) won't be affected by.

Basically, puppet defaults the value of seluser based on what it thinks it should be. But, there's a caching issue and it never rechecks after a new selinux policy is loaded. You need to restart the puppet service... :(

}

file { "${forwarder_confdir}/system/local/deploymentclient.conf":
Expand Down