Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/TinyGsmClientSequansMonarch.h: use PDP context #1 #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ffontaine
Copy link
Contributor

PDP Context #1 is working perfectly with GMS01Q

Signed-off-by: Fabrice Fontaine [email protected]

PDP Context vshymanskyy#1 is working perfectly with GMS01Q

Signed-off-by: Fabrice Fontaine <[email protected]>
@SRGDamia1
Copy link
Collaborator

I'm fairly certain I was using context 3 because on the VZM20Q contexts one and two are pre-set to Verizon configurations so 3 is the first available. Does context 3 not work on the other module? If context 3 does work for it and the change is just more-or-less cosmetic, I don't want to change it.

@ffontaine
Copy link
Contributor Author

PDP context #3 is mostly working, there is a single issue with one the embedded applet which does not work as expected because it assumes that thee is a single PDP context. Do you think it would be acceptable to update this PR to allow an advanced user to configure its PDP context?

@SRGDamia1
Copy link
Collaborator

@ffontaine - could you set the context number as a define/pre-processor flag? That would allow anyone to change it if necessary without forcing them to set it if they don't want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants