Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1199) 보관함 > λ‚΄ ν”Œλ¦¬ 상세 μ§„μž… μ‹œ ν”Œλ‘œνŒ… λ²„νŠΌ μœ„μΉ˜ μ•ˆλ§žλŠ” UI 였λ₯˜ μˆ˜μ • #1201

Merged
merged 3 commits into from
Aug 20, 2024
Merged

πŸ”€ :: (#1199) 보관함 > λ‚΄ ν”Œλ¦¬ 상세 μ§„μž… μ‹œ ν”Œλ‘œνŒ… λ²„νŠΌ μœ„μΉ˜ μ•ˆλ§žλŠ” UI 였λ₯˜ μˆ˜μ • #1201

merged 3 commits into from
Aug 20, 2024

Conversation

KangTaeHoon
Copy link
Contributor

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • ν”Œλ‘œνŒ… λ²„νŠΌ μœ„μΉ˜κ°€ μ•ˆλ§žμŒ

Resolves: #1199

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • ν”Œλ‘œνŒ… λ²„νŠΌ μœ„μΉ˜ μ‘°μ •

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

  • μ΅œλŒ€ν•œ μ½”λ“œλ₯Ό 적게 μž‘μ„±ν•˜λ € ν–ˆμœΌλ‚˜, 이게 μ΅œμ„ μœΌλ‘œ κ²°λ‘  μ§€μŒ.

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added the 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ label Aug 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon merged commit 183dfc8 into release/3.0.0 Aug 20, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 1199-ui-fix-fab-in-my-playlist-detail branch August 20, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KangTaeHoon @yongbeomkwak @youn9k