Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1231) ν¬λ ˆλ”§ μž‘μ—…μž λ…Έλž˜ λ¦¬μŠ€νŠΈμ—μ„œ 썸넀일 클릭 μ‹œ μž¬μƒλͺ©λ‘μ˜ 첫 곑으둜 μ΄λ™λ˜λŠ” 이슈 ν•΄κ²° #1233

Merged
merged 2 commits into from
Aug 26, 2024
Merged

πŸ”€ :: (#1231) ν¬λ ˆλ”§ μž‘μ—…μž λ…Έλž˜ λ¦¬μŠ€νŠΈμ—μ„œ 썸넀일 클릭 μ‹œ μž¬μƒλͺ©λ‘μ˜ 첫 곑으둜 μ΄λ™λ˜λŠ” 이슈 ν•΄κ²° #1233

merged 2 commits into from
Aug 26, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

ν¬λ ˆλ”§ μž‘μ—…μž λ…Έλž˜ λ¦¬μŠ€νŠΈμ—μ„œ 썸넀일 클릭 μ‹œ μž¬μƒλͺ©λ‘μ˜ 첫 곑으둜 μ΄λ™λ˜λŠ” 이슈 ν•΄κ²°

Resolves: #1231

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • ν¬λ ˆλ”§ μž‘μ—…μž λ…Έλž˜ λ¦¬μŠ€νŠΈμ—μ„œ 썸넀일 클릭 μ‹œ μž¬μƒλͺ©λ‘μ˜ 첫 곑으둜 μ΄λ™λ˜λŠ” 이슈 ν•΄κ²°
  • ν‘Έμ‹œμ•Œλ¦Όμ—μ„œ λ…Έλž˜ 상세 μ§„μž… μ‹œ μž¬μƒλͺ©λ‘μ˜ 첫 곑으둜 μ΄λ™λ˜λŠ” 이슈 ν•΄κ²°
  • λ…Έλž˜ 상세가 λ…ΈμΆœλ˜λŠ” 쀑에 μž¬μƒλͺ©λ‘ 첫번째 곑 이미지가 λ³΄μ˜€λ‹€κ°€ λ‘œλ“œλ˜λ©΄ λ°”λ€ŒλŠ” 이슈 ν•΄κ²°

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨ labels Aug 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 25, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun force-pushed the 1231-credit-song-list-detail-is-navigate-playlist-first branch from cd908be to c2c31c7 Compare August 25, 2024 16:56
@baekteun baekteun force-pushed the 1231-credit-song-list-detail-is-navigate-playlist-first branch from 507f581 to 9f06a8e Compare August 26, 2024 13:03
@baekteun baekteun merged commit 6d3a715 into release/3.0.0 Aug 26, 2024
3 checks passed
@baekteun baekteun deleted the 1231-credit-song-list-detail-is-navigate-playlist-first branch August 26, 2024 15:18
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baekteun @KangTaeHoon