Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#512) v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ - Chart Domain #540

Merged
merged 16 commits into from
May 15, 2024

Conversation

KangTaeHoon
Copy link
Contributor

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ - Chart Domain

Resolves: #512

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • api ๋ณ€๊ฒฝ์  ์ ์šฉ - Chart Domain
  • ๋ถˆํ•„์š” ์š”์†Œ ์‚ญ์ œ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

  • '๋ˆ„์ ์ˆœ'์ด ์‚ฌ๋ผ์กŒ์Œ
  • ์—…๋ฐ์ดํŠธ ์‹œ๊ฐ„ ๊ฐ€์ ธ์˜ค๋Š” api๊ฐ€ ์—†์Œ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented May 13, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon changed the base branch from develop to 511-update-domain-artist May 13, 2024 16:26
๐Ÿ”€ :: (#507) v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ - Song Domain
@KangTaeHoon KangTaeHoon merged commit 9f41d37 into 511-update-domain-artist May 15, 2024
2 checks passed
@KangTaeHoon KangTaeHoon deleted the 512-update-domain-chart branch May 15, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChartDomain - API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜
3 participants