Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#544) Chart Domain ๋ณ€๊ฒฝ์  ์ ์šฉ 2nd #545

Merged
merged 4 commits into from
May 17, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented May 15, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๐Ÿ”€ :: (#544) Chart Domain ๋ณ€๊ฒฝ์  ์ ์šฉ 2nd

Resolves: #544

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Array โ†’ ChartDto ๋กœ ๋ณ€๊ฒฝ๋จ
  • FetchChartUpdateTimeUseCase ์ œ๊ฑฐ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added the โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ label May 15, 2024
Copy link

github-actions bot commented May 15, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon changed the title ๐Ÿ”€ :: (#544) Chard Domain ๋ณ€๊ฒฝ์  ์ ์šฉ 2nd ๐Ÿ”€ :: (#544) Chart Domain ๋ณ€๊ฒฝ์  ์ ์šฉ 2nd May 15, 2024
@KangTaeHoon KangTaeHoon merged commit 4f00c0a into develop May 17, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 544-update-domain-chart branch May 17, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChartDomain - API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ (2nd)
3 participants