Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 :: (#546) Artist Domain 변경점 적용 2nd #547

Merged
merged 1 commit into from
May 16, 2024

Conversation

KangTaeHoon
Copy link
Contributor

💡 배경 및 개요

🔀 :: (#546) Artist Domain 변경점 적용 2nd

Resolves: #546

📃 작업내용

  • artistListResponseDTO에 id값 추가.
  • name.kr을 id로 사용하던 구문 제거

🙋‍♂️ 리뷰노트

✅ PR 체크리스트

템플릿 체크리스트 말고도 추가적으로 필요한 체크리스트는 추가해주세요!

  • 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
  • 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
  • 작업한 코드가 정상적으로 동작하나요?
  • Merge 대상 브랜치가 올바른가요?
  • PR과 관련 없는 작업이 있지는 않나요?

🎸 기타

@github-actions github-actions bot added the ⚡️ Simple 간단한 변경사항 label May 16, 2024
Copy link

github-actions bot commented May 16, 2024

✅ Successful finished SwiftLint

Copy link

✅ Assign 자동 지정을 성공했어요!

@KangTaeHoon

Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@KangTaeHoon KangTaeHoon merged commit d71fc21 into 544-update-domain-chart May 16, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 546-update-domain-artist branch May 16, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡️ Simple 간단한 변경사항
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants