Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikibase-cloud-clusterissuers v0.2.0: add local ClusterIssuer #179

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

deer-wmde
Copy link
Contributor

https://phabricator.wikimedia.org/T378691

This adds a self-signed cert ClusterIssuer in order to use TLS in our local environment via cert-manager.

https://cert-manager.io/docs/configuration/

Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I imagine we may want to iterate on this by allowing people to pass in a CA that they have trusted in their browser but that's surely version 2.0

@deer-wmde
Copy link
Contributor Author

Looks good to me; I imagine we may want to iterate on this by allowing people to pass in a CA that they have trusted in their browser but that's surely version 2.0

You mean for convenience? probably more easy for most of us to dismiss the scary warning heh (although I'm not really a fan of that either, bad habit injection)

@deer-wmde deer-wmde added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 43ffdd3 Dec 10, 2024
2 checks passed
@deer-wmde deer-wmde deleted the de/cloud-clusterissuer-local branch December 10, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants