Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace optional with required in paper #146

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

penqee
Copy link
Contributor

@penqee penqee commented Dec 21, 2024

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

这个 PR 做了什么 / 我们为什么需要这个 PR?

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

不要随意用空指针哩

@penqee penqee requested review from jiuxia211, ozline and a team as code owners December 21, 2024 08:37
@jiuxia211
Copy link
Contributor

本修改是为了兼容旧版Android,认为返回值使用optional 更加合理一些

@jiuxia211 jiuxia211 merged commit 0f00988 into west2-online:main Dec 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants