feat: umeng broadcast message #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #153 +/- ##
========================================
- Coverage 3.12% 3.11% -0.01%
========================================
Files 184 185 +1
Lines 38335 38418 +83
========================================
Hits 1197 1197
- Misses 37073 37156 +83
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@penqee 来 check，没问题的话 approve 然后合了 |
mutezebra
reviewed
Jan 11, 2025
pkg/umeng/broadcast.go
Outdated
|
|
||
| req, err := http.NewRequest("POST", url+"?sign="+sign, bytes.NewBuffer(postBody)) | ||
| if err != nil { | ||
| return fmt.Errorf("umeng.sendBroadcast : failed to create request: %w", err) |
There was a problem hiding this comment.
这里应该用 errno.Errorf 吧. 这里是错误产生的地方, 我们需要调用栈
pkg/umeng/broadcast.go
Outdated
| client := &http.Client{} | ||
| resp, err := client.Do(req) | ||
| if err != nil { | ||
| return fmt.Errorf("umeng.sendBroadcast : failed to send request: %w", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自查 PR 结构
PR 标题符合这个格式: <type>(optional scope): <description>
此 PR 标题的描述以用户为导向，足够清晰，其他人可以理解。
我已经对所有 commit 提供了签名（GPG 密钥签名、SSH 密钥签名）
这个 PR 属于强制变更/破坏性更改
这个 PR 的类型是什么？
这个 PR 做了什么 / 我们为什么需要这个 PR？
(可选)这个 PR 解决了哪个/些 issue？
对 Reviewer 预留的一些提醒