Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use filebeat to uniformly collect logs to es #165

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mutezebra
Copy link
Member

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

这个 PR 做了什么 / 我们为什么需要这个 PR?

使用 filebeat 统一收集日志信息并发送到 es
修复了之前某次 PR 产生的一个小 bug

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

@mutezebra mutezebra requested review from ozline, jiuxia211 and a team as code owners January 21, 2025 16:09
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/base/pack.go 25.00% 3 Missing ⚠️
@@           Coverage Diff            @@
##            main    #165      +/-   ##
========================================
+ Coverage   3.26%   3.30%   +0.03%     
========================================
  Files        199     199              
  Lines      40233   40237       +4     
========================================
+ Hits        1314    1330      +16     
+ Misses     38842   38831      -11     
+ Partials      77      76       -1     
Flag Coverage Δ
unittest 3.30% <62.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/logger/logger.go 63.84% <100.00%> (+1.14%) ⬆️
pkg/base/pack.go 50.87% <25.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant