Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support storage of user basic info and get cultivate plan #55

Merged
merged 18 commits into from
Jan 12, 2025
Merged

Conversation

renbaoshuo
Copy link
Member

🚧 This pull request is under progress, DO NOT MERGE IT! 🚧


只存学号对应的年级、学院信息,别的一概不存。

@FantasyRL
Copy link
Member

我会继续推进这个pr

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 4.31138% with 1598 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
kitex_gen/user/user.go 0.00% 484 Missing ⚠️
kitex_gen/academic/academic.go 0.00% 366 Missing ⚠️
kitex_gen/user/k-user.go 0.00% 307 Missing ⚠️
kitex_gen/academic/k-academic.go 0.00% 259 Missing ⚠️
internal/academic/service/get_plan.go 29.72% 23 Missing and 3 partials ⚠️
internal/user/handler.go 0.00% 21 Missing ⚠️
...ex_gen/academic/academicservice/academicservice.go 4.54% 21 Missing ⚠️
kitex_gen/user/userservice/userservice.go 4.54% 21 Missing ⚠️
pkg/base/context/login_data.go 0.00% 17 Missing ⚠️
api/rpc/academic.go 0.00% 10 Missing ⚠️
... and 11 more
@@           Coverage Diff            @@
##            main     #55      +/-   ##
========================================
+ Coverage   3.12%   3.25%   +0.13%     
========================================
  Files        184     192       +8     
  Lines      38335   40016    +1681     
========================================
+ Hits        1197    1303     +106     
- Misses     37073   38646    +1573     
- Partials      65      67       +2     
Flag Coverage Δ
unittest 3.25% <4.31%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/handler/api/academic_service.go 6.30% <100.00%> (+6.30%) ⬆️
internal/user/service/get_info.go 100.00% <100.00%> (ø)
internal/user/service/get_logindata.go 100.00% <100.00%> (+100.00%) ⬆️
internal/user/service/service.go 100.00% <100.00%> (+100.00%) ⬆️
kitex_gen/academic/academicservice/server.go 0.00% <ø> (ø)
kitex_gen/user/userservice/server.go 0.00% <ø> (ø)
pkg/db/user/create_student.go 100.00% <100.00%> (ø)
pkg/db/user/get_student.go 100.00% <100.00%> (ø)
pkg/db/user/user.go 100.00% <100.00%> (ø)
pkg/db/db.go 0.00% <0.00%> (ø)
... and 20 more

... and 7 files with indirect coverage changes

@FantasyRL FantasyRL changed the title Add storage of user basic info Add storage of user basic info and get cultivate plan Jan 10, 2025
@FantasyRL FantasyRL marked this pull request as ready for review January 10, 2025 06:10
@FantasyRL FantasyRL requested review from jiuxia211, mutezebra, ozline and a team as code owners January 10, 2025 06:10
@ozline
Copy link
Member

ozline commented Jan 11, 2025

目前这个 pr 还有什么没完工的吗?

@FantasyRL
Copy link
Member

FantasyRL commented Jan 11, 2025

目前这个 pr 还有什么没完工的吗?

已完工,但get cultivate plan写的很丑
比如httpClient这个东西我要不要放到clientSet,或者直接在jwch那边处理

pkg/db/user/get_student.go Outdated Show resolved Hide resolved
pkg/db/user/create_student.go Outdated Show resolved Hide resolved
api/handler/api/academic_service.go Outdated Show resolved Hide resolved
ozline
ozline previously approved these changes Jan 12, 2025
Signed-off-by: ozlinex <[email protected]>
@ozline ozline changed the title Add storage of user basic info and get cultivate plan feat: support storage of user basic info and get cultivate plan Jan 12, 2025
@ozline ozline merged commit 9b0170f into main Jan 12, 2025
8 checks passed
@ozline ozline deleted the user-db branch January 12, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants