[WFLY-7132] Improve logging of exceptions during embedded process exit

wildfly · Jan 20, 2025 · 7b89469 · 7b89469
1 parent bb00e4a
commit 7b89469
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/embedded/src/main/java/org/wildfly/core/embedded/AbstractEmbeddedManagedProcess.java b/embedded/src/main/java/org/wildfly/core/embedded/AbstractEmbeddedManagedProcess.java
@@ -177,10 +177,10 @@ private void exit() {
             } catch (RuntimeException rte) {
                 throw rte;
             } catch (InterruptedException ite) {
-                EmbeddedLogger.ROOT_LOGGER.error(ite.getLocalizedMessage(), ite);
+                logExitError(ite);
                 Thread.currentThread().interrupt();
             } catch (Exception ex) {
-                EmbeddedLogger.ROOT_LOGGER.error(ex.getLocalizedMessage(), ex);
+                logExitError(ex);
             }
 
             embeddedProcess.getProcessStateNotifier().removeProcessStateListener(processStateListener);
@@ -196,10 +196,10 @@ private void exit() {
             } catch (RuntimeException rte) {
                 throw rte;
             } catch (InterruptedException ite) {
-                EmbeddedLogger.ROOT_LOGGER.error(ite.getLocalizedMessage(), ite);
+                logExitError(ite);
                 Thread.currentThread().interrupt();
             } catch (Exception ex) {
-                EmbeddedLogger.ROOT_LOGGER.error(ex.getLocalizedMessage(), ex);
+                logExitError(ex);
             }
         }
 
@@ -209,4 +209,8 @@ private void exit() {
             embeddedProcess = null;
         }
     }
+
+    private void logExitError(Exception ex) {
+        EmbeddedLogger.ROOT_LOGGER.errorExitingEmbeddedProcess(ex, type.getLogForm(), ex.getLocalizedMessage());
+    }
 }
diff --git a/embedded/src/main/java/org/wildfly/core/embedded/logging/EmbeddedLogger.java b/embedded/src/main/java/org/wildfly/core/embedded/logging/EmbeddedLogger.java
@@ -202,4 +202,8 @@ public interface EmbeddedLogger extends BasicLogger {
     @Message(id = 146, value = "Failed to restore context %s")
     @LogMessage(level = Logger.Level.ERROR)
     void failedToRestoreContext(@Cause Throwable cause, Context context);
+
+    @Message(id = 147, value = "Error exiting embedded %s: %s")
+    @LogMessage(level = Logger.Level.ERROR)
+    void errorExitingEmbeddedProcess(@Cause Throwable cause, String processType, String error);
 }
diff --git a/embedded/src/main/java/org/wildfly/core/embedded/spi/EmbeddedProcessBootstrap.java b/embedded/src/main/java/org/wildfly/core/embedded/spi/EmbeddedProcessBootstrap.java
@@ -5,6 +5,8 @@
 
 package org.wildfly.core.embedded.spi;
 
+import java.util.Locale;
+
 /**
  * Service interface that standalone server or host controller bootstrap logic can implement
  * to allow their type of process to be bootstrapped in an embedded environment.
@@ -13,7 +15,11 @@ public interface EmbeddedProcessBootstrap {
 
     enum Type {
         STANDALONE_SERVER,
-        HOST_CONTROLLER
+        HOST_CONTROLLER;
+
+        public String getLogForm() {
+            return name().toLowerCase(Locale.ENGLISH).replace("_", " ");
+        }
     }
 
     /**